Implement LLE-GCM #3096

jarveson · 2017-07-26T03:16:33Z

Implements support for lle of GCM.

LLE turned to auto / default as major regression seems to be found and fixed
HLE still functions as well as it did (with some fixes), but will need to be manually coded out
Report any regressions found with lle now

mention-bot · 2017-07-26T03:16:36Z

@jarveson, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Nekotekina, @vlj and @acmiyaguchi to be potential reviewers.

Nekotekina · 2017-07-26T09:28:35Z

rpcs3/Emu/Cell/lv2/sys_rsx.cpp

+	if (!m_sysrsx)
+		fmt::throw_exception("sys_rsx_context_allocate called twice.");
+
+	vm::falloc(0x40000000, 0x10000000, vm::rsx_context);


It doesn't seem necessary to allocate 256 MB for this

If no one else can use it in the PS3, it doesn't matter, the OS will lazy alloc it anyway...

On linux - maybe. You normally shouldn't rely on such an idea.

On Windows, too, its saved in a VAD.
Anyway, I'd agree with you on other types of applications, but as this is virtual memory on virtual memory, I believe it'll faster than checking if you need to alloc more in realtime. It isn't wasted memory, too, because it isn't used and no one will access it, so it shouldn't page fault.

Yea ill resize it to something smaller

Nekotekina · 2017-07-26T09:34:18Z

rpcs3/Emu/Memory/vm.cpp

@@ -783,6 +783,7 @@ namespace vm
 			{
 				std::make_shared<block_t>(0x00010000, 0x1FFF0000), // main
 				std::make_shared<block_t>(0x20000000, 0x10000000), // user
+				std::make_shared<block_t>(0x40000000, 0x30000000), // rsx contexts


Put this at the end of the list. Why 0x30000000?

lv1/2 allows 3 rsx contexts i think, with vsh normally at 0x60000000, game context is at 0x40000000, so i assume it gives the full 0x10000000 for each context. Also, why end of list?

I put this down to 0x10000000 because it seemed to force sonic unleashed to be unable to vm_map with it taking so much memory, may have to be looked into what actually is used by ps3 then

Nekotekina · 2017-07-26T09:34:58Z

rpcs3/Emu/Memory/vm.h

@@ -16,6 +16,7 @@ namespace vm
 	{
 		main,
 		user_space,
+		rsx_context,


This is unnecessary

the code very much depends currently on being able to get the 0x40000000 allocation for context, unless there is a better way to do it that im missing?

You don't need this. First 4 entries are special and they aren't required to allocate something with falloc.

Ooh, i see now, k ill make the changes

Xcedf · 2017-07-27T05:53:59Z

Now this branch even greater after being able to swithch between LLE and HLE gcm, but lle-gcm had some issues and hle also has it now
what kind of issue could this be

Some other games also has the same
from my list its
SH Downpour
Bulletstorm
Spec Ops The Line
And btw, will be gcm module removed from lv2 ignore list?

jarveson · 2017-07-27T08:51:26Z

@Xcedf are these regressions with HLE? For now ive opened issue #3105 to track issues like the ones you've mentioned with lle, although if they happen with HLE now, that changes things

Xcedf · 2017-07-27T12:43:53Z

@jarveson yes, they happen with hle now too

jarveson · 2017-07-27T14:17:02Z

Fixed zcull issue which should remove regressions that happened

Xcedf · 2017-07-27T17:18:04Z

Confirm fixed now

Xcedf · 2017-07-28T06:01:46Z

fixed screen update issue in Metal Gear Revengeance

AniLeo · 2017-07-31T14:49:08Z

Any other regressions? Should be good for merge 🔜 if not

Illynir · 2017-07-31T15:25:17Z

I don't know if this a regression but in Kingdom Heart 1 on KH 1.5 Remix HD the shadows of characters flicker a little. On master, they aren't flicker at all and are perfect. (With write color buffer else there are no shadows at all on master and LLE GCM)

Then... I don't know if it's because write color buffer in combination with LLE GCM or not or if it's really a regression.

For the rest, no problem to report.

Igihara · 2017-07-31T17:36:58Z

Controlled character moves slow when the analog stick is moved diagonally on this build(?) using xinput. Blog build doesn't have that issue.

AniLeo · 2017-07-31T17:38:18Z

This build doesn't touch XInput and the blog build is not a master

Inviuz · 2017-07-31T17:46:57Z

Probably related to recent xinput changes, try changing Pad Squircling Factor in config_xinput.yml to 4000

fifazalata · 2017-07-31T19:00:10Z

@Igihara If you mean running diagonally in P5, then try changing
Pad Squircling Factor: from 8000 to 4000 in the "config_xinput.yml" file
That should fix the problem.

Igihara · 2017-08-01T11:19:41Z

Changing it to 4000 fixed it. Thanks guys.

Kubokoo · 2017-08-02T21:36:32Z

In master version with this pull, persona 5 in menus there is some black piece of that covers text.
(RPCS3 v0.0.3-8-b396826 Alpha
Intel(R) Core(TM) i5-4670K CPU @ 3.40GHz | 4 Threads | 15.69 GiB RAM | AVX)

In older version (RPCS3 v0.0.3-5587-5b61dcdc Alpha) this problem does not exists.

jarveson · 2017-08-03T00:39:39Z

try with #3135 @Kubokoo

Kubokoo · 2017-08-03T07:45:29Z

On a freshly compiled version (without #3135 ) I got this:

With #3135 I got this (there still is some black part, but it does not cover text anymore):

Kravickas · 2017-08-07T13:00:18Z

This broke NHL 15 to not rendering anything

I think it cos u deleted

-		/*
-
-		// Store previous fbo addresses to detect RTT config changes.
-		std::array<u32, 4> m_previous_color_address = {};
-		u32 m_previous_address_z = 0;
-		u32 m_previous_target = 0;
-		u32 m_previous_clip_horizontal = 0;
-		u32 m_previous_clip_vertical = 0;
-		*/

2 previous build were getting E {rsx::thread} RSX: FBO check failed: 0x8cd6, but it was rendering game.

Nekotekina reviewed Jul 26, 2017

View reviewed changes

AniLeo added Bugfix Render: Direct3D 12 Enhancement Firmware: HLE RSX labels Jul 26, 2017

jarveson mentioned this pull request Jul 27, 2017

LLE-GCM Regressions #3105

Closed

SakataGintokiYT mentioned this pull request Jul 29, 2017

MEM: Access violation reading location 0x0 with "libgcm_sys.sprx" selected in P5 #3121

Closed

AniLeo requested a review from Nekotekina August 1, 2017 17:57

jarveson added 4 commits August 1, 2017 12:58

rsx/gcm: Implement rsx dma. Refactor gcm/rsx to not be as codependent

b48f00e

sys_rsx: implement support for lle-gcm

44c43a1

d3d12: Fix 0 sized framebuffer crashes

a640c52

Add gcm to auto lle / liblv2

9f34a87

Nekotekina merged commit 02845f5 into RPCS3:master Aug 1, 2017

jarveson deleted the lle-gcm-pr2 branch August 2, 2017 01:34

TotalCaesar659 mentioned this pull request Aug 3, 2017

F1 2010: "Fragment shader(s) were not successfully compiled..." #3071

Closed

Kravickas mentioned this pull request Aug 7, 2017

Regression - NHL 15 #3156

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement LLE-GCM #3096

Implement LLE-GCM #3096

jarveson commented Jul 26, 2017 •

edited

mention-bot commented Jul 26, 2017

Nekotekina Jul 26, 2017

Farseer2 Jul 26, 2017

Nekotekina Jul 26, 2017

Farseer2 Jul 26, 2017 •

edited

jarveson Jul 27, 2017

Nekotekina Jul 26, 2017

jarveson Jul 27, 2017 •

edited

jarveson Jul 27, 2017

Nekotekina Jul 26, 2017

jarveson Jul 27, 2017

Nekotekina Jul 27, 2017

jarveson Jul 27, 2017

Xcedf commented Jul 27, 2017

jarveson commented Jul 27, 2017 •

edited

Xcedf commented Jul 27, 2017

jarveson commented Jul 27, 2017

Xcedf commented Jul 27, 2017

Xcedf commented Jul 28, 2017

AniLeo commented Jul 31, 2017

Illynir commented Jul 31, 2017 •

edited

Igihara commented Jul 31, 2017

AniLeo commented Jul 31, 2017

Inviuz commented Jul 31, 2017

fifazalata commented Jul 31, 2017

Igihara commented Aug 1, 2017

Kubokoo commented Aug 2, 2017 •

edited

jarveson commented Aug 3, 2017

Kubokoo commented Aug 3, 2017

Kravickas commented Aug 7, 2017 •

edited

Implement LLE-GCM #3096

Implement LLE-GCM #3096

Conversation

jarveson commented Jul 26, 2017 • edited

mention-bot commented Jul 26, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Farseer2 Jul 26, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jarveson Jul 27, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Xcedf commented Jul 27, 2017

jarveson commented Jul 27, 2017 • edited

Xcedf commented Jul 27, 2017

jarveson commented Jul 27, 2017

Xcedf commented Jul 27, 2017

Xcedf commented Jul 28, 2017

AniLeo commented Jul 31, 2017

Illynir commented Jul 31, 2017 • edited

Igihara commented Jul 31, 2017

AniLeo commented Jul 31, 2017

Inviuz commented Jul 31, 2017

fifazalata commented Jul 31, 2017

Igihara commented Aug 1, 2017

Kubokoo commented Aug 2, 2017 • edited

jarveson commented Aug 3, 2017

Kubokoo commented Aug 3, 2017

Kravickas commented Aug 7, 2017 • edited

jarveson commented Jul 26, 2017 •

edited

Farseer2 Jul 26, 2017 •

edited

jarveson Jul 27, 2017 •

edited

jarveson commented Jul 27, 2017 •

edited

Illynir commented Jul 31, 2017 •

edited

Kubokoo commented Aug 2, 2017 •

edited

Kravickas commented Aug 7, 2017 •

edited